feat: Expose action parameters: group, level, rate, step size and transition time#12683
Open
andrei-lazarov wants to merge 7 commits into
Open
feat: Expose action parameters: group, level, rate, step size and transition time#12683andrei-lazarov wants to merge 7 commits into
andrei-lazarov wants to merge 7 commits into
Conversation
Contributor
Author
|
Also I don't like how they are separate entities. Maybe we can rework in Z2M 3.0.0? "voltage": 2500,
"action": "off",
"action_group": 21658 "voltage": 2500,
"action": {
"command": "off",
"group": 21658
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit for easier review
This pull request exposes the following entities for remotes that use standard functions
m.commandsCluster():action_groupaction_levelaction_rateaction_step_sizeaction_transition_timeI covered only OnOff and LevelControl clusters.
More should be aded in the future, for ColorControl, Scenes, WindowCovering:
action_hue,action_direction,action_saturation,action_coloretc.These parameters were already published to MQTT, just not exposed.
Should be no functionality changes, just easier use. It makes them show up in WF, HA and docs.
I triggered a docgen to check the results: andrei-lazarov/zigbee2mqtt.io@6daf67e
And of course I tested locally